On Thu, Sep 01, 2011 at 09:53:34AM +0800, David Henningsson wrote:
> > Hi Col,
> >
> > Do you think it's better to invoke pa_thread_new("alsa-sink 0", func, u)
> > or adding another index after the plain name? (e.g.
> > pa_thread_new("alsa-sink", index, func, u))
> >
>
> Having seen this in action for a while I'd say I like the idea in
> general, but I have a few things to wish for if possible:
Hi David,
Thanks for your suggestions.
>
> 1) Yes, having "alsa-sink 0" (for whatever 0 means, sink index, module
> index) is helpful, e g when you have four soundcards and get an
> "Underrun from ALSA!" message and don't know what card that is. My
> favorite would be if you can get the ALSA shortname in (e g "alsa-sink
> SB" or "alsa-sink Headset") but I don't know if that's easy enough to do.
>
> 2) If we can eliminate this information from the main thread (empty
> brackets or just remove it altogether), that would reduce most of the
> log size increased by this patch.
On point 2, do you mean "[pulseaudio] xxxx" should be better changed to
"[] xxxx" or "xxxx" instead? I agree it's annoying to see lots of
"pulseaudio" messages on the log.
I can help to make our debugging life easier. :)
--
guanqun
