On Mon, 2011-10-03 at 21:57 +0300, R?mi Denis-Courmont wrote: > Le lundi 3 octobre 2011 21:50:52 Pierre-Louis Bossart, vous avez ?crit : > > > +#if PA_CHECK_VERSION(1,0,0) > > > + case VLC_CODEC_A52: > > > + format = VLC_CODEC_SPDIFL; > > > + encoding = PA_ENCODING_AC3_IEC61937; > > > + ss.format = HAVE_FPU ? PA_SAMPLE_FLOAT32NE : > > > PA_SAMPLE_S16NE; > > > + break; > > > > This test doesn't seem right. Probably a copy/paste mistake? The IEC data > > need to be stored in 16-bit data no matter if your hardware has a FPU or > > not. > > That is the fallback PCM format in case the sink rejects S/PDIF. That ALSA > wants S16 for S/PDIF is the internal cooking of the PulseAudio sink, right? Yes. However, I got confused when I saw that code the first time as well. Maybe a comment there would be useful. Will test with this new code tomorrow and let you know how it goes. Cheers, Arun
