2011/6/8 Maarten Bosmans <mkbosmans at gmail.com>: > 2011/6/8 Arun Raghavan <arun.raghavan at collabora.co.uk>: >> On Tue, 2011-06-07 at 23:50 +0200, Maarten Bosmans wrote: >>> This makes windows.h include less headers. >>> Otherwise boolean is typedef'ed and that clashes with libjson. Hmm, it seems that this patch did not really solve the problem, as I forgot to put the #define in pulsecore/socket.h. >> Why not add this to CFLAGS in configure for the win32 case? > > I considered to enable it globally, but then decided to leave the > decision in the case someone want the whole windows.h header. It's a > pretty weak argument though and I myself am not fully convinced, > because perhaps it's better to not let windows.h include a whole lot > of different headers, but include them manually when needed (as I did > in this patch for the winsock2.h case) So that oversight pretty much argues for defining globally. Attached is a patch that does that and superseeds the previous patch. > Using AC_DEFINE instead of adding to CFLAGS would be preferable IMHO, > to keep the visual clutter for make V=1 a bit in check. Maarten -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-win32-define-WIN32_LEAN_AND_MEAN.patch Type: application/octet-stream Size: 1120 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20110608/392ce9b4/attachment.obj>
