2011/6/8 Arun Raghavan <arun.raghavan at collabora.co.uk>: > On Tue, 2011-06-07 at 23:50 +0200, Maarten Bosmans wrote: >> This makes windows.h include less headers. >> Otherwise boolean is typedef'ed and that clashes with libjson. > > Why not add this to CFLAGS in configure for the win32 case? I considered to enable it globally, but then decided to leave the decision in the case someone want the whole windows.h header. It's a pretty weak argument though and I myself am not fully convinced, because perhaps it's better to not let windows.h include a whole lot of different headers, but include them manually when needed (as I did in this patch for the winsock2.h case) Using AC_DEFINE instead of adding to CFLAGS would be preferable IMHO, to keep the visual clutter for make V=1 a bit in check. Maarten > Cheers, > Arun
