On Fri, 2011-12-02 at 17:33 +0200, Tanu Kaskinen wrote: > On Fri, 2011-12-02 at 11:37 +0100, David Henningsson wrote: > > I think they are all good catches, and I just posted a patch to fix this > > up (although I was lazy enough to use a goto for the last fix, maybe I > > should refactor the entire function a bit?). > > That would be nice. I think it would be also good to have the fixes in > separate patches. For the record, I have now pushed the fixup patch in its current form. David agreed to do the refactoring in a separate patch. -- Tanu
