On Fri, 2011-12-02 at 11:37 +0100, David Henningsson wrote: > Having property lists on ports is something desirable for all of us. > Would you mind applying the patch I just posted? We could use that as a > base - I could add it to the client API I'm working on, and you could > work on parsing configuration files. Yes, I'll probably push the patch soon (after this discussion about whether to wait is finished). > > The remaining issues: > > > > * If mapping_probe_paths() fails to open the mixer, it's not handled > > very well. If that happens, I think all paths should be removed from the > > mapping's path sets. > > * pa_path_set.probed isn't really used for anything (pretty cosmetic > > issue). > > * If profile probing is configured to be skipped, mapping_paths_probe() > > won't be called, and path sets won't be created. > > > > Would you possibly have the time and energy to address these problems? > > I think they are all good catches, and I just posted a patch to fix this > up (although I was lazy enough to use a goto for the last fix, maybe I > should refactor the entire function a bit?). That would be nice. I think it would be also good to have the fixes in separate patches. > Ok. Maybe we should revert paths_dir altogether if nobody's else > depending on it? Yes, I think so. -- Tanu
