On Mon, Dec 16, 2024 at 9:46 AM Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx> wrote: > Andy and I disagree about this change. If you happen to not have the > patch in your inbox, see > https://lore.kernel.org/linux-pwm/3a99048a52aeee356d01dbf7f2f06e6e0826ed78.1733245406.git.ukleinek@xxxxxxxxxx/ > > Would you please volunteer as the impartial judge here as you're the > upstream maintainer of drivers/pinctrl/intel/pinctrl-intel.c? What about those wise lines from Torvalds in Documentation/process/management-style.rst: The name of the game is to **avoid** having to make a decision. In particular, if somebody tells you "choose (a) or (b), we really need you to decide on this", you're in trouble as a manager. The people you manage had better know the details better than you, so if they come to you for a technical decision, you're screwed. You're clearly not competent to make that decision for them. > The TL;DR; is: Do you prefer a single MODULE_IMPORT_NS() in a header, or > should every consumer driver explicitly have its own MODULE_IMPORT_NS() > invokation? Intuitively I personally prefer using macros like that in every instance (in every consumer driver). But it's not like I can give any good reason for it, just intuition and what I would do. Yours, Linus Walleij
