On Wed, 10 Jul 2024, Hans de Goede wrote: > On 7/6/24 3:09 PM, Ilpo Järvinen wrote: > > On Tue, 2 Jul 2024, Shyam Sundar S K wrote: > > > >> At present, the PMF driver employs custom system state codes to update > >> system states. It is recommended to replace these with existing input > > > > This change entirely removes the way userspace worked before this change? > > We cannot take userspace functionality away like this. > > I completely agree with you that we cannot just go and remove existing > userspace API. > > But AFAICT in this case no known userspace code has ever actually started > relying on these custom udev events. The docs suggest creating a custom > udev rules files which I don't believe any distributions have actually > done, not has this been made part of the default udev rules shipped > with systemd. > > So I think in this case we can get away with removing the udev event > generation and the sooner we do so, the smaller the chance something > does actually start depending on it. > > And if I'm wrong it should be easy to add back the udev event generation > and send both the udev events and the key-presses. Okay, thanks for chimming in. -- i.
