On Tue, 2 Jul 2024, Shyam Sundar S K wrote: > At present, the PMF driver employs custom system state codes to update > system states. It is recommended to replace these with existing input > event codes (KEY_SLEEP, KEY_SUSPEND, and KEY_SCREENLOCK) to align system > updates with the PMF-TA output actions. > > Co-developed-by: Patil Rajesh Reddy <Patil.Reddy@xxxxxxx> > Signed-off-by: Patil Rajesh Reddy <Patil.Reddy@xxxxxxx> > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> > --- > @@ -475,6 +506,10 @@ int amd_pmf_init_smart_pc(struct amd_pmf_dev *dev) > if (pb_side_load) > amd_pmf_open_pb(dev, dev->dbgfs_dir); > > + ret = amd_pmf_register_input_device(dev); > + if (ret) > + goto error; > + > return 0; > > error: > @@ -488,6 +523,9 @@ void amd_pmf_deinit_smart_pc(struct amd_pmf_dev *dev) > if (pb_side_load && dev->esbin) > amd_pmf_remove_pb(dev); > > + if (dev->pmf_idev) > + input_unregister_device(dev->pmf_idev); > + Why is the ordering in the init and deinit asymmetric? Is that intentional? -- i. > cancel_delayed_work_sync(&dev->pb_work); > kfree(dev->prev_data); > dev->prev_data = NULL;
