Hi Pavel, On 7/10/24 11:58 AM, Pavel Machek wrote: > Hi! > >> From: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> [ Upstream commit 38a38f5a36da9820680d413972cb733349400532 ] >> >> When support for Silead touchscreens was orginal added some touchscreens >> with older firmware versions only supported 5 fingers and this was made >> the default requiring the setting of a "silead,max-fingers=10" uint32 >> device-property for all touchscreen models which do support 10 fingers. >> >> There are very few models with the old 5 finger fw, so in practice the >> setting of the "silead,max-fingers=10" is boilerplate which needs to >> be copy and pasted to every touchscreen config. >> >> Reporting that 10 fingers are supported on devices which only support >> 5 fingers doesn't cause any problems for userspace in practice, since >> at max 4 finger gestures are supported anyways. Drop the max_fingers >> configuration and simply always assume 10 fingers. > > This does not fix a serious bug, should not be in stable. This patch is necessary for clean backporting of new DMI quirks added to drivers/platform/x86/touchscreen_dmi.c, so IMHO it does make sense as a stable series patch. Regards, Hans