On Sat, Mar 23, 2024 at 12:02 AM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Fri, Mar 22, 2024 at 7:45 AM Kate Hsuan <hpa@xxxxxxxxxx> wrote: > > On Tue, Mar 12, 2024 at 7:04 AM Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > ... > > > > > + chip->num_leds = (unsigned long)i2c_get_match_data(client); > > > > > > No warnings during compilation? > > Yes, the compiler doesn't complain about it. > > And for 32-bit mode as well? > Hi Andy, I've tested it with 32bits kernel build and the compiler didn't complain about the warnings. > ... > > P.S. You have commented only on the two comments. What about the rest? For the rest, including variable renaming, error number shadowing, and "%pfw" were fixed in the v5 patch. I sent the patch but I forgot to add you. I'll resend the v5 patch and keep you in the loop. Thank you :) > > -- > With Best Regards, > Andy Shevchenko > -- BR, Kate
