On Fri, Mar 22, 2024 at 7:45 AM Kate Hsuan <hpa@xxxxxxxxxx> wrote: > On Tue, Mar 12, 2024 at 7:04 AM Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: ... > > > + chip->num_leds = (unsigned long)i2c_get_match_data(client); > > > > No warnings during compilation? > Yes, the compiler doesn't complain about it. And for 32-bit mode as well? ... P.S. You have commented only on the two comments. What about the rest? -- With Best Regards, Andy Shevchenko