Hi,
On 2/10/24 16:06, Andy Shevchenko wrote:
> On Sat, Feb 10, 2024 at 1:01 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>>
>> Since commit 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler
>> for SCI") the ACPI OSL code passes IRQF_ONESHOT when requesting the SCI.
>>
>> Since the INT0002 GPIO is typically shared with the ACPI SCI the INT0002
>> driver must pass the same flags.
>>
>> This fixes the INT0002 driver failing to probe due to following error +
>> as well as removing the backtrace that follows this error:
>>
>> "genirq: Flags mismatch irq 9. 00000084 (INT0002) vs. 00002080 (acpi)"
>
> While this seems the correct fix, I'm wondering why this driver can't
> instead subscribe to a GPE event. See how gpio-sch does this.
This is modelled in ACPI as a separate device with its own IRQ,
so we are just following how this is modelled in ACPI here.
And IIRC I think not all BYT/CHT devices which use this
driver hac a SCI defined in their ACPI tables and without
a SCI there are no GPE events.
Regards,
Hans
