Hi,
On 2/10/24 12:01, Hans de Goede wrote:
> Since commit 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler
> for SCI") the ACPI OSL code passes IRQF_ONESHOT when requesting the SCI.
>
> Since the INT0002 GPIO is typically shared with the ACPI SCI the INT0002
> driver must pass the same flags.
>
> This fixes the INT0002 driver failing to probe due to following error +
> as well as removing the backtrace that follows this error:
>
> "genirq: Flags mismatch irq 9. 00000084 (INT0002) vs. 00002080 (acpi)"
>
> Fixes: 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler for SCI")
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
I've added this to my review-hans (soon to be fixes) branch now.
Regards,
Hans
> ---
> drivers/platform/x86/intel/int0002_vgpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/x86/intel/int0002_vgpio.c
> index b6708bab7c53..527d8fbc7cc1 100644
> --- a/drivers/platform/x86/intel/int0002_vgpio.c
> +++ b/drivers/platform/x86/intel/int0002_vgpio.c
> @@ -196,7 +196,7 @@ static int int0002_probe(struct platform_device *pdev)
> * IRQs into gpiolib.
> */
> ret = devm_request_irq(dev, irq, int0002_irq,
> - IRQF_SHARED, "INT0002", chip);
> + IRQF_ONESHOT | IRQF_SHARED, "INT0002", chip);
> if (ret) {
> dev_err(dev, "Error requesting IRQ %d: %d\n", irq, ret);
> return ret;
