Re: [PATCH] platform/x86: intel: int0002_vgpio: Pass IRQF_ONESHOT to request_irq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Sat, Feb 10, 2024 at 1:01 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Since commit 7a36b901a6eb ("ACPI: OSL: Use a threaded interrupt handler
> for SCI") the ACPI OSL code passes IRQF_ONESHOT when requesting the SCI.
> Since the INT0002 GPIO is typically shared with the ACPI SCI the INT0002
> driver must pass the same flags.
> This fixes the INT0002 driver failing to probe due to following error +
> as well as removing the backtrace that follows this error:
> "genirq: Flags mismatch irq 9. 00000084 (INT0002) vs. 00002080 (acpi)"

While this seems the correct fix, I'm wondering why this driver can't
instead subscribe to a GPE event. See how gpio-sch does this.

With Best Regards,
Andy Shevchenko

[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux