El mié, 2 nov 2022 a la(s) 22:15, Guenter Roeck (linux@xxxxxxxxxxxx) escribió: > > On Wed, Nov 02, 2022 at 06:10:37PM -0300, Joaquin Aramendia wrote: > > > > > > > > Oops. Is not really needed but I'll add them. > > > > > > > Technically you are correct, but we would have static analyzers scream at > > > us, and it is against kernel coding style. There is a practical reason > > > for that: Missing break statements are often the result of coding errors. > > > > > > Guenter > > > > Great, thanks for the clarification. > > > > As for my last statement, module_platform_driver() usage broke the > > module, don't know why, but seems like the probe function is not run? > > If you are ok with it, I'll revert to module_init/module_exit macros. > > > Go ahead, just add a comment to the driver. Mabe someone manages > to sort it out. > > Thanks, > Guenter Will add that comment, rebase and submit again the patch. Thanks for your time, Guenter. And sorry If I got on your nerves :) -- Joaquín I. Aramendía
