On Thu, Nov 03, 2022 at 11:15:12PM -0700, Joseph, Jithu wrote: > If these doesn’t alleviate your concern, I will post v2 without > exporting the aforementioned functions and implementing them > separately in IFS driver as you suggested. So tglx persuaded me yesterday that we should do code sharing after all, so that all blob loading remains consistent. So let's try the cpu/intel.c thing and see what breaks, how and when. As to patch 8, that metadata checking should not be part of microcode_intel_sanity_check() but a separate function. Along with microcode_intel_find_meta_data() - all those should go into the IFS thing. When microcode loading ends up really needing metadata, *then* that functionality should be lifted into a more fitting place like cpu/intel.c Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette