> > > > Oops. Is not really needed but I'll add them. > > > Technically you are correct, but we would have static analyzers scream at > us, and it is against kernel coding style. There is a practical reason > for that: Missing break statements are often the result of coding errors. > > Guenter Great, thanks for the clarification. As for my last statement, module_platform_driver() usage broke the module, don't know why, but seems like the probe function is not run? If you are ok with it, I'll revert to module_init/module_exit macros. -- Joaquín I. Aramendía