On Sat, Dec 25, 2021 at 1:55 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> Driver for the external-charger IRQ pass-through function of the
> Bay Trail Crystal Cove PMIC.
Intel Bay Trail (same in the code)
> Note this is NOT a power_supply class driver, it just deals with IRQ
> pass-through, this requires this separate driver because the PMIC's
> level 2 interrupt for this must be explicitly acked.
>
> This new driver gets enabled by the existing X86_ANDROID_TABLETS Kconfig
> option because the x86-android-tablets module is the only user of the
> exported external-charger IRQ.
...
> drivers/platform/x86/crystal_cove_charger.c | 153 ++++++++++++++++++++
I'm wondering why it's not under the intel/ subfolder. Do we expect to
have the same PMIC used on other x86 vendors?
...
> +static int crystal_cove_charger_probe(struct platform_device *pdev)
> +{
Adding
struct device *dev = &pdev->dev;
may increase readability a bit and perhaps reduce the amount of LOCs.
--
With Best Regards,
Andy Shevchenko
