On Sat, Dec 25, 2021 at 1:55 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > The cells for the Crystal Cove PMIC are already mostly sorted by > function / IRQ order. Move the ADC cell so that they are fully sorted. > > Also move some of the resource definitions so that their order matches > the (new) order of the cells. ... > #define CRYSTAL_COVE_IRQ_GPIO 5 > { As Lee commented once in p2sb patch series I think it makes sense here as well, i.e. [CRYSTAL_COVE_IRQ_GPIO] = { > .name = "crystal_cove_gpio", > .num_resources = ARRAY_SIZE(gpio_resources), What do you think? -- With Best Regards, Andy Shevchenko