Re: [ PATCH v2 1/1] dell smbios driver : Consider Alienware a valid OEM String

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 10/9/20 11:24 AM, Pali Rohár wrote:
On Friday 09 October 2020 11:14:33 Hans de Goede wrote:
Hi,

On 10/9/20 10:26 AM, Pali Rohár wrote:
On Friday 09 October 2020 02:33:49 Gerardo Esteban Malazdrewicz wrote:
dell-laptop doesn't even load as is ('No such device')

However, adding an entry in dell_device_table, based on dmidecode
output (Vendor: Alienware, Type: 10), allows it to load.

But I don't know how to test for any of this additional functionality.

What should I look for?

Hello! dell-laptop driver provides following features:

* rfkill interface for enabling/disabling wifi and bluetooth
    - check presence of "*dell*" by /sbin/rfkill utility

* backlight interface for controlling display brightness
    - check presence of "dell_backlight" in /sys/class/backlight/

* touchpad led (if your touchpad has some led)
    - check presence of "dell-laptop::touchpad" in /sys/class/leds

* configuring keyboard backlight
    - check presence of "dell::kbd_backlight" in /sys/class/leds

* led for microphone mute
    - check presence of "platform::micmute" in /sys/class/leds

Thanks Pali, that is a great answer.
...
Pali, can you perhaps make a similar feature list for
the dell-wmi driver ?

dell-wmi is just listener for events delivered by WMI interface. All
events are currently delivered only via input device to userspace as
most of the events are key pressed or other similar events which maps to
input device. Looking at the code, there is one exception about event
KEY_KBDILLUMTOGGLE which is delivered to dell-laptop driver to notify it
when dell firmware itself decided to change keyboard backlight level.

...
Note that the dell-wmi driver also depends on the
dell-smbios-base module, so you should also check if the
dell-wmi driver offers any additional functionality
on your laptop (if it does then that would also be a reason
to move forward with your dell-smbios-base patch).

For two Dell laptops (Dell Inspiron M5110 and Dell Vostro V131) it is
needed to call special SMBIOS function to enable receiving those WMI
events. Therefore dell-wmi checks via DMI table if that special call is
required then use dell-smbios-base module to issue needed call.

So theoretically if some key press events are not delivered on
particular dell laptop, it is a good idea to add it on that
dell_wmi_smbios_list, special SMBIOS call would be issued and check if
something is changed... But for now we know only 2 laptops which
required it (or better only 2 people complained that not all key press
events are delivered and verified that special SMBIOS call was
required).

Right, so Gerardo, I guess the laptop keyboard will have
some special hotkeys (possibly in combination with the "Fn")
keys as shortcuts for various things.

It would be good if you can verify that all those hotkeys
generate events.

What you can do is run "sudo evemu-record" and then select e.g.
first the "AT Translated Set 2 keyboard" device and see which
(special hotkey) keys generate events there. Then strike those
of the list to check and next check the "Dell WMI hotkeys"
device and see if any hotkeys report events there.

Note the display brightness up/down hotkeys might very well be
delivered through the "Video Bus" event. More in general you may
have some other input devices which deal with some of the hotkeys.

Regards,

Hans




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux