>
> Hans, there are more drivers which checks for Dell DMI strings. Probably
> it would be needed to update Alienware on more places, not only in
> dell-smbios-base.c driver.
I would prefer that each of those be checked on a case by case basis and only
added if actually necessary. Gerardo if you can please check any other drivers
that should need this string added to their allow list.
>
> >
> >
> > >
> > > Alienware has been a subsidiary of Dell since 2006.
> > >
> > > 2020 Alienware laptop:
> > > $ sudo dmidecode | head -3
> > > # dmidecode 3.2
> > > Getting SMBIOS data from sysfs.
> > > SMBIOS 3.2.0 present.
> > > $ sudo dmidecode | grep -A 29 "OEM Strings"
> > > OEM Strings
> > > String 1: Alienware
> > > String 2: 1[099B]
> > > String 3: 3[1.0]
> > > String 4: 4[0001]
> > > String 5: 5[0000]
> > > String 6: 6[D0, D4, D8, DA, DE]
> > > String 7: 7[]
> > > String 8: 8[]
> > > String 9: 9[]
> > > String 10: 10[1.3.0]
> > > String 11: 11[]
> > > String 12: 12[]
> > > String 13: 13[P38E002]
> > > String 14: 14[0]
> > > String 15: 15[0]
> > > String 16: 16[0]
> > > String 17: 17[0000000000000000]
> > > String 18: 18[0]
> > > String 19: 19[1]
> > > String 20: 20[]
> > > String 21: 21[]
> > > String 22: <BAD INDEX>
> > > String 23: <BAD INDEX>
> > > String 24: <BAD INDEX>
> > > String 25: <BAD INDEX>
> > > String 26: <BAD INDEX>
> > > String 27: <BAD INDEX>
> > > String 28: <BAD INDEX>
> > >
> > > 2013 Alienware laptop:
> > > OEM Strings
> > > String 1: Dell System
> > > String 2: 1[05AA]
> > > String 3: 14[2]
> > > String 4: 15[0]
> > > String 5: String5 for Original Equipment Manufacturer
> > >
> > > Don't know when the OEM String changed.
> > > Change tested in the 2020 laptop, loads dell_smbios without further
> > > issues.
> > >
> > > Signed-off-by: Gerardo E. Malazdrewicz <gerardo@xxxxxxxxxxxxxxxxxxx>
> > > Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> > > ---
> > > drivers/platform/x86/dell-smbios-base.c | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/platform/x86/dell-smbios-base.c
> > > b/drivers/platform/x86/dell-smbios-base.c
> > > index 2e2cd565926aa..5ad6f7c105cf3 100644
> > > --- a/drivers/platform/x86/dell-smbios-base.c
> > > +++ b/drivers/platform/x86/dell-smbios-base.c
> > > @@ -564,7 +564,8 @@ static int __init dell_smbios_init(void)
> > > int ret, wmi, smm;
> > > if (!dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System",
> > > NULL) &&
> > > - !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com",
> > > NULL)) {
> > > + !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "www.dell.com",
> > > NULL) &&
> > > + !dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Alienware",
> > > NULL)) {
> > > pr_err("Unable to run on non-Dell system\n");
> > > return -ENODEV;
> > > }
> > >
> > >
> > >
> >
