Re: [PATCH v5] asus-nb-wmi: add support for ASUS ROG Zephyrus G14 (GA401) and G15 (GA502)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, den 03.08.2020, 19:47 +0300 schrieb Andy Shevchenko:
> +Cc: Jonathan.
> (newbie's adventures below)
> 
> On Mon, Aug 3, 2020 at 7:39 PM Armas Spann <
> zappel@xxxxxxxxxxxxx
> > wrote:
> 
> > I think I missed that checklist.. But what I was looking for was some kind
> > of a
> > "quick"-list, like that one you send me some weeks ago. (howto use git to
> > send
> > those emails, for example)
> > 
> > For a newcomer like me in this process, it's hard to sort out the right
> > information and where to put description/changelog/etc. in the (git)patch
> > itself. It might be helpful to have an example for a full git-driven patch
> > (IMHO) - Yes of course I looked in to other submitted patches to get a clou.
> > Because after reading all the kernel howtos to submit and participate, I
> > felt
> > more lost then before due to the informational overflow.
> > 
> > And of course, that I screwed up the branch/repo in my last patches was
> > totally
> > my fault because I did not recognized that I need to checkout another repo
> > and
> > branch to get ontop of my/your previously applied patch in this case.
> > 
> > 
> > Im very thankful for all the support you gave me, but I think I should have
> > asked first, before submitting patches. ;)
> 
> But your evaluation of [1] will be quite helpful exactly b/c you are a newbie!
> Maybe you can read it again and propose changes that will help people
> like you now (I believe you will learn things fast) to be not lost on
> the first steps?
> 
> > Best regards and thanks for your feedback,
> > Armas
> 
> Please, avoid top postings in the future. It's not welcome by the community.
> 
> ...
> 
> > > Do you think we need to expand / update checklist [1] in kernel
> > > documentation?
> > > 
> > > [1]:
> > > https://www.kernel.org/doc/html/latest/process/submit-checklist.html
> > > 
> 
> 

Got it. 
(Today I'm learning howto write an email - really feeling like a noob now) 
- just changed my mailer settings to answer below.

To answer your question about [1]:
That checklist is pretty streight forward and understandable, my problem was
more the linked 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#submittingpatches
 documentation. Which especially confuses me reading the "changlog" sections.
It's not clear (to me at least) where to put which changelog. I know the default
changelog is what a patch changes and that should go directly under the subject.
But the internal (patch related) changelog was totally unclear. As well as this
documentation is missing the git send-email thingy you pointed me to (its only
mentioned once within '#explicit-in-reply-to-headers').


Best regards,
Armas




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux