Re: [PATCH v5] asus-nb-wmi: add support for ASUS ROG Zephyrus G14 (GA401) and G15 (GA502)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

I think I missed that checklist.. But what I was looking for was some kind of a
"quick"-list, like that one you send me some weeks ago. (howto use git to send
those emails, for example)

For a newcomer like me in this process, it's hard to sort out the right
information and where to put description/changelog/etc. in the (git)patch
itself. It might be helpful to have an example for a full git-driven patch
(IMHO) - Yes of course I looked in to other submitted patches to get a clou.
Because after reading all the kernel howtos to submit and participate, I felt
more lost then before due to the informational overflow.

And of course, that I screwed up the branch/repo in my last patches was totally
my fault because I did not recognized that I need to checkout another repo and
branch to get ontop of my/your previously applied patch in this case.


Im very thankful for all the support you gave me, but I think I should have
asked first, before submitting patches. ;)



Best regards and thanks for your feedback,
Armas

Am Montag, den 03.08.2020, 16:00 +0300 schrieb Andy Shevchenko:
> On Mon, Aug 3, 2020 at 2:55 PM Armas Spann <
> zappel@xxxxxxxxxxxxx
> > wrote:
> > Yeah sorry..
> 
> NP.
> 
> > just recognized that I totally messed it up. (first issue, I was on the
> > wrong
> > branch/repo, second you're totally right with the two structs, one is way
> > better
> >  - like it's implemented now.)
> > 
> > I just recognized that it is fixed in the "for-next" branch with slightly
> > adjusted fixes you applied. Many thanks.
> > 
> > So, please just ignore the last requests from me. I'll take care the next
> > time
> > when doing a submit, to crosscheck everything more then once. (I've now a
> > checklist for that purpose ^^)
> 
> Do you think we need to expand / update checklist [1] in kernel documentation?
> 
> [1]: 
> https://www.kernel.org/doc/html/latest/process/submit-checklist.html
> 
> 
> 





[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux