Yeah sorry..
just recognized that I totally messed it up. (first issue, I was on the wrong
branch/repo, second you're totally right with the two structs, one is way better
- like it's implemented now.)
I just recognized that it is fixed in the "for-next" branch with slightly
adjusted fixes you applied. Many thanks.
So, please just ignore the last requests from me. I'll take care the next time
when doing a submit, to crosscheck everything more then once. (I've now a
checklist for that purpose ^^)
Best regards,
Armas
Am Sonntag, den 02.08.2020, 13:59 +0300 schrieb Andy Shevchenko:
> On Sun, Aug 2, 2020 at 7:17 AM Armas Spann <
> zappel@xxxxxxxxxxxxx
> > wrote:
> >
>
> Drop extra blank line(s) here.
>
> > This patch adds the ASUS ROG Zephyrus G14/15 notebook series detection to
>
> Read the Submitting Patches section about "This patch" and fix text
> accordingly.
>
> > asus-nb-wmi. The detection itself is accomplished by adding two new
> > quirk_entry
> > structs (one for each series), as well as all current available G401/G502
> > DMI_PRODUCT_NAMES to match the corresponding devices.
> > patch-changelog:
> > v1: initial G401 patches
> > v2: --
> > v3: re-initial GA401 and GA502 and setting description
> > v4: corrected typo(s) added GA502DU series
> > v5: corrected signed-off position in patch - sorry
>
> This must go after the cutter '---' line below.
>
> > Signed-off-by: Armas Spann <
> > zappel@xxxxxxxxxxxxx
> > >
> > ---
>
> ...
>
> > +static struct quirk_entry quirk_asus_ga401 = {
> > + .wmi_backlight_power = true,
> > + .wmi_backlight_set_devstate = true,
> > +};
> > +
> > +static struct quirk_entry quirk_asus_ga502 = {
> > + .wmi_backlight_power = true,
> > + .wmi_backlight_set_devstate = true,
> > +};
>
> These are identical. What is the point?
>
>
> P.S. Have you based your stuff on our for-next branch [1]?
>
> [1]:
> http://git.infradead.org/linux-platform-drivers-x86.git/shortlog/refs/heads/for-next
>
>
>
