On Tue, Jan 21, 2020 at 05:06:56PM +0000, Mark Brown wrote: > On Tue, Jan 21, 2020 at 07:00:22PM +0200, Mika Westerberg wrote: > > > OK, thanks for the clarification. I guess in this case we can probably > > just live without using it, if that's fine for Lee and others. The new > > MFD driver itself is ~500 lines so not sure how much regmap would help > > there, and we only expose two simple functions for the subdevices both > > dealing with 64-bit registers. > > The usual motivation is all the diagnostic infrastructure you get with > regmap - tracepoints for I/O and the ability to dump the register map in > debugfs mainly. Right. Here we are talking about a "map" of two registers so probably not worth the added trouble ;-)