On Tue, Jan 21, 2020 at 04:21:57PM +0000, Mark Brown wrote: > On Tue, Jan 21, 2020 at 07:00:36PM +0300, Mika Westerberg wrote: > > > Currently both intel_scu_ipc.c and intel_pmc_ipc.c implement the same SCU > > IPC communications with minor differences. This duplication does not make > > much sense so this series reworks the two drivers so that there is only a > > single implementation of the SCU IPC. In addition to that the API will be > > This is a 40 (!) patch series and looking at the subjects and diffstat I > can't tell if there's something in particular that you're looking for me > to review? Sorry about that. I included you because there was suggestion from Lee to convert the MFD driver in patch 37 to use regmap but the registers are all 64-bit and it was not clear whether regmap supports that: https://www.spinics.net/lists/platform-driver-x86/msg20652.html Looking at the regmap API it seems to deal mostly with "unsigned int" which does not work well with the 64-bit MMIO registers but I may be missing something.
