On Tue, Jan 21, 2020 at 07:01:10PM +0300, Mika Westerberg wrote: > kstrtoul() already returns negative error if the input was not valid so > return it directly. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > --- > drivers/platform/x86/intel_pmc_ipc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c > index f912f2a40512..eb4d65768531 100644 > --- a/drivers/platform/x86/intel_pmc_ipc.c > +++ b/drivers/platform/x86/intel_pmc_ipc.c > @@ -226,8 +226,9 @@ static ssize_t intel_pmc_ipc_northpeak_store(struct device *dev, > int subcmd; > int ret; > > - if (kstrtoul(buf, 0, &val)) > - return -EINVAL; > + ret = kstrtoul(buf, 0, &val); > + if (ret) > + return ret; > > if (val) > subcmd = 1; > -- > 2.24.1 > -- With Best Regards, Andy Shevchenko
