On Thu, Jan 11, 2018 at 10:38 AM, David Herrmann <dh.herrmann@xxxxxxxxx> wrote: > On Wed, Jan 10, 2018 at 4:03 PM, Andy Shevchenko > <andy.shevchenko@xxxxxxxxx> wrote: >> On Tue, Jan 9, 2018 at 10:24 PM, Matthew Thode <mthode@xxxxxxxxxx> wrote: >> Just realized that it might be an ambient sensor. Your hand makes >> light goes differently to the sensor -> hardware sends an event. >> >> Whatever guys, feel free to submit a patch when you will be sure what >> is the source of the event. >> >> It also makes sense to discuss somewhere near to thinkwiki.org I suppose. > > Indeed. I can reliably trigger it by moving my hand on top of the > arrow-keys. 0x60b0 is signaled when hovered. It has a latency of > roughly 1s. Once I remove my hand, 0x60b1 is signalled, with a latency > of roughly 3s. Overall, the sensor is quite unreliable when I actually > use the laptop. Sometimes to a degree that it does not react to > anything at all. It might really be some ambient light sensor, which > then gets confused by some unexpected lighting. > > Whatever it is, I think this is really meant as "palm-detection" so > input drivers can disable trackpads, etc. I would listen to what Henrique said, he has a good point. > I'd be fine with the patch Matthew proposed (makes the sensor a no-op): > https://www.snip2code.com/Snippet/3291964/0001-Add-Thinkpad-palm-detection-acpi-co/ > > Andy, is there any reason not to merge it? Do you want this key to be > exposed in some way? If the patch is ok, I can test it locally and > resend with tested-by. I can't just crawl through internet and merge odd patches. This is one reason why I added the author to Cc list. Another one we have an established process, so, please follow it: 1) submit to mailing list (like you did your initial message); 2) get time to be reviewed. We also use patchwork to keep history of what has been done. This patch missed our patchwork queue. Another important point I have no hardware to test myself, so, I need to be crystal clear on the change. I can't for this particular one. So, and at the end we have alive maintainer for that code. W/o his ACK I would not proceed. Sorry for inconvenience, this is how it's supposed to work. -- With Best Regards, Andy Shevchenko
