Re: [PATCH] platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 25, 2017 at 06:51:31AM +0200, Michał Kępień wrote:
> > > Finally, it seems the S6120 also has a row of "application panel"
> > > hotkeys above the keyboard, but lacks the FUJ02E3 ACPI device, so I am
> > > wondering whether these hotkeys work in Linux.  Ville, do they?
> > 
> > They work via the apanel driver.
> 
> Oops, then it looks like we have two drivers which poke the same
> hardware at the same time using different methods: apanel uses SMBus,
> fujitsu-laptop uses ACPI (the former is inferior as it resorts to
> polling, which causes key presses to be reported with a delay).  I just
> loaded both drivers on my Fujitsu Lifebook S7020 and it results in
> duplicate events being passed to userspace.  We should probably prevent
> this, but I am not quite sure how to achieve that.

Maybe in apanel probe?

#if ENABLED(FUJITSU_LAPTOP)
	if (ACPI thing available)
		fail;
#endif

-- 
Ville Syrjälä
Intel OTC



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux