Re: [PATCH] platform/x86: fujitsu-laptop: Don't oops when FUJ02E3 is not presnt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Finally, it seems the S6120 also has a row of "application panel"
> > hotkeys above the keyboard, but lacks the FUJ02E3 ACPI device, so I am
> > wondering whether these hotkeys work in Linux.  Ville, do they?
> 
> They work via the apanel driver.

Oops, then it looks like we have two drivers which poke the same
hardware at the same time using different methods: apanel uses SMBus,
fujitsu-laptop uses ACPI (the former is inferior as it resorts to
polling, which causes key presses to be reported with a delay).  I just
loaded both drivers on my Fujitsu Lifebook S7020 and it results in
duplicate events being passed to userspace.  We should probably prevent
this, but I am not quite sure how to achieve that.

Darren, Andy, do you have any thoughts on this?

> Well, there's buttons 1-4 and Enter.
> Buttons 1-4 work but the Enter doesn't, but that could be just an
> oversight in the apanel driver.

No, this is the way it is supposed to work.  Or at least fujitsu-laptop
does not react to the Enter key being pressed either.

> That's at least how the S6010 works.
> I'll have to retest the S6120 to make sure it behaves the same way.
> At least it has the same set of buttons on it.
> 
> > In
> > fact, it would be super helpful if you could post acpidumps from all
> > three models you have access to (you mentioned S6120, S6010 and S7110).
> > IMHO the biggest issue we have had while refactoring fujitsu-laptop is a
> > narrow set of known/tested models.
> 
> I've attached acpidumps and dmidecode outputs for all three machines.

Thank you!  This helps a lot and will definitely help preventing similar
issues in the future.

-- 
Best regards,
Michał Kępień



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux