On Mon, Sep 18, 2017 at 11:00:59PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > My Fujitsu-Siemens Lifebook S6120 doesn't have the FUJ02E3 device, > but it does have FUJ02B1. That means we do register the backlight > device (and it even seems to work), but the code will oops as soon > as we try to set the backlight brightness because it's trying to I'm curious by what you mean with "it even seems to work". Since it crashes when adjusting, what does it do that "works" ? > call call_fext_func() with a NULL device. Let's just skip those > function calls when the FUJ02E3 device is not present. > Interesting. We call call_fext_func from many locations using the "device" argument, or the driver static "fext". This looks to me that we should be a bit more consistent here. Finally, it seems a proper fix would be to either not register the backlight device if !fext or to check for !fext inside call_fext_func. Jonathan, your thoughts? -- Darren Hart VMware Open Source Technology Center
