> > My Fujitsu-Siemens Lifebook S6120 doesn't have the FUJ02E3 device, > > but it does have FUJ02B1. That means we do register the backlight > > device (and it even seems to work), but the code will oops as soon > > as we try to set the backlight brightness because it's trying to > > call call_fext_func() with a NULL device. Let's just skip those > > function calls when the FUJ02E3 device is not present. > > Oh, the irony... I have literally just sat down to dust off the patch > series I have had queued for the past couple of months which makes the > driver for FUJ02B1 a separate module depending on the FUJ02E3 driver. > Then I saw your email and it is now clear that such a dependency is > bogus. AFAIR, until now everyone involved was expecting the FUJ02E3 > ACPI device to be present on all Fujitsu laptops. > > I need to refresh my memory a bit and think about next steps. This comment of mine seems a bit too hotheaded in retrospect. The fact that we cannot assume that FUJ02E3 always exists when FUJ02B1 exists does not prevent us from exposing a function from a module centered around the former to the module centered around the latter. That function would just need to correctly handle a missing FUJ02E3 ACPI device. Thus, I am still supportive of splitting the module into two. > I still > have one more cleanup series queued that is worth posting and I also > need to fix radio LED detection. My spare time is still very limited, > but I will do my best to post something soon. The aforementioned patch series is still queued on my disk, but needs a bit more polishing before I can post it. This is just a "keepalive" message that I have not given up on it. -- Best regards, Michał Kępień
