On Tue, Aug 18, 2015 at 04:50:56PM +0100, Matt Fleming wrote: > On Mon, 2015-08-10 at 16:04 +0100, Shevchenko, Andriy wrote: > > > > Matt, by the way intel_pmc_ipc.c module creates iTCO device (LPC bus). > > Does it look correct? > > Yeah, it looks OK to me. Note there are changes queued up in Lee Jones' > tree for changing the lpc_ich_info into itco_wdt_platform_data. > > Btw, is there a reason that intel_pmc_ipc doesn't use the mfd_* API > since it's concerned with multiple functions? > Qipeng? > I saw the v2 come in, but didn't see this question addressed in the changelog. When design P-unit driver, we got feedback from BIOS that there will allocate a dedicate ACPI id for P-unit controller, and finally BIOS decide not do that, just put some necessary Resource in PMC acpi table. After that, we got request to do same thing for iTco. I agree it's better to update pmc driver to use mfd_add_devices to create punit and iTco device. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
