On Sat, Aug 22, 2015 at 01:04:19AM +0800, Qipeng Zha wrote: > This driver provides support for P-Unit mailbox IPC on Intel platforms. > The heart of the P-Unit is the Foxton microcontroller and its firmware, > which provide mailbox interface for power management usage. > > Signed-off-by: Qipeng Zha <qipeng.zha@xxxxxxxxx> Hi Qipeng, 0-day/lkp raised a couple of issues please review that report. I immediately hit a build failure: $ make allmodconfig $ make drivers/platform/x86/intel_punit_ipc.ko CC drivers/platform/x86/intel_punit_ipc.o In file included from drivers/platform/x86/intel_punit_ipc.c:20:0: ./arch/x86/include/asm/intel_punit_ipc.h:87:16: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘int’ static intline int intel_punit_ipc_simple_command(int cmd, ^ ./arch/x86/include/asm/intel_punit_ipc.h:89:1: error: expected identifier or ‘(’ before ‘{’ token { ^ ./arch/x86/include/asm/intel_punit_ipc.h:95:1: error: expected identifier or ‘(’ before ‘{’ token { ^ scripts/Makefile.build:258: recipe for target 'drivers/platform/x86/intel_punit_ipc.o' failed make[1]: *** [drivers/platform/x86/intel_punit_ipc.o] Error 1 Makefile:1550: recipe for target 'drivers/platform/x86/intel_punit_ipc.ko' failed make: *** [drivers/platform/x86/intel_punit_ipc.ko] Error 2 -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html