Re: [PATCH] Platform: hp-wmi: add rfkill support for integrated GPS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 11, 2012 at 03:15:47PM +0200, Trepák Vilmos wrote:
> On Thu, 2012-10-11 at 13:34 +0100, Matthew Garrett wrote:
> > I don't think this bit is right - in this codepath, wireless is a mask, 
> > so 0x3 would mean wifi and bluetooth, not gps. I'd expect gps to be 0x8.
> 
> And you'd expect right. Re-tested with 0x8, it works.

Ok.

> >  
> > The rest looks good, though.
> > 
> 
> Of course it does, it's just copy & paste & replace... I don't even
> think I deserve credit for it.
> 
> Is it worth it to resubmit the patch for a 1-byte change or will you
> just take care of it yourself? If it's easier for you, I'll resubmit.

No worries, I'll fix it up. Thanks!

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux