On Thu, Oct 11, 2012 at 12:51:00PM +0200, Trepák Vilmos wrote: > @@ -663,6 +669,24 @@ static int __devinit hp_wmi_rfkill_setup > goto register_bluetooth_error; > } > > + if (wireless & 0x3) { > + gps_rfkill = rfkill_alloc("hp-gps", &device->dev, > + RFKILL_TYPE_GPS, > + &hp_wmi_rfkill_ops, > + (void *) HPWMI_GPS); I don't think this bit is right - in this codepath, wireless is a mask, so 0x3 would mean wifi and bluetooth, not gps. I'd expect gps to be 0x8. The rest looks good, though. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html