On Thu, 2012-10-11 at 13:34 +0100, Matthew Garrett wrote:
> On Thu, Oct 11, 2012 at 12:51:00PM +0200, Trepák Vilmos wrote:
> > @@ -663,6 +669,24 @@ static int __devinit hp_wmi_rfkill_setup
> > goto register_bluetooth_error;
> > }
> >
> > + if (wireless & 0x3) {
> > + gps_rfkill = rfkill_alloc("hp-gps", &device->dev,
> > + RFKILL_TYPE_GPS,
> > + &hp_wmi_rfkill_ops,
> > + (void *) HPWMI_GPS);
>
> I don't think this bit is right - in this codepath, wireless is a mask,
> so 0x3 would mean wifi and bluetooth, not gps. I'd expect gps to be 0x8.
And you'd expect right. Re-tested with 0x8, it works.
>
> The rest looks good, though.
>
Of course it does, it's just copy & paste & replace... I don't even
think I deserve credit for it.
Is it worth it to resubmit the patch for a 1-byte change or will you
just take care of it yourself? If it's easier for you, I'll resubmit.
--
Trepák Vilmos <trepo@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
