On Tue, Nov 22, 2011 at 11:18 PM, Greg KH <gregkh@xxxxxxx> wrote: > On Tue, Nov 22, 2011 at 11:02:36PM +0100, Corentin Chary wrote: >> * SABI command are on 16 bits, not 8 > > Are you sure about that? I guess this would work, and we rely on the > bits being in the right order so everything works properly? Yep, I'm pretty sure this is the case, but I've not yet found a command using more than 8 bits. Anyway the 16 bit code works flawlessly here since we were already using "writew(command, ...);" since the beginning. Regarding the bits order, the driver depends on X86, so I don't see this as a real issue. >> * SABI can read/write up to 11 byte of data > > It can? That's how it seems to work, but I didn't see any command using more that 24 bits yet. >> * There is not real difference between "get" and "set" >> commands, so refactorise the code of both functions > > Ah, nice, I always wanted to do that. > >> Signed-off-by: Corentin Chary <corentincj@xxxxxxxxxx> > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx> > > -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
