On Tue, Nov 22, 2011 at 11:19 PM, Greg KH <gregkh@xxxxxxx> wrote: > On Tue, Nov 22, 2011 at 11:02:33PM +0100, Corentin Chary wrote: >> Create _init()/_exit() function for each subsystem, remove >> the local struct samsung_laptop * and only keep a >> struct platform_device * that can only be used in samsung_init() >> and samsung_exit(). >> >> Signed-off-by: Corentin Chary <corentincj@xxxxxxxxxx> > > It seems a little gratitous, but hey, if you want to maintain this > driver, I have no objection to you rewriting the thing :) > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx> Well, doing that seems to help with error paths, and make it easy separate functionalities, in my opinion. -- Corentin Chary http://xf.iksaif.net -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
