Re: [PATCH 05/15] samsung-laptop: ehance SABI support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 22, 2011 at 11:02:36PM +0100, Corentin Chary wrote:
> * SABI command are on 16 bits, not 8

Are you sure about that?  I guess this would work, and we rely on the
bits being in the right order so everything works properly?

> * SABI can read/write up to 11 byte of data

It can?

> * There is not real difference between "get" and "set"
>   commands, so refactorise the code of both functions

Ah, nice, I always wanted to do that.

> Signed-off-by: Corentin Chary <corentincj@xxxxxxxxxx>

Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux