Re: [PATCH 10/25] sony-laptop: keyboard backlight support extended to newer Vaios

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Il 04/06/2011 13:23, Mattia Dongili ha scritto:
Just for safety, since handle 0x0000 is a valid handle [1] it would
be better to initialize it to an invalid value.

0x0 is not valid, it's just the lack of a value.

But you can use it. "Just for safety" we'd better set to an invalid value that cannot be used by the acpi methods.

[1]
sony_laptop: found handle 0x0000 (offset: 0x0d)
sony_laptop: called SN07 with 0x000d (result: 0x0000)

this is only going through the handles buffer and telling you that at
0x0d there is nothing.

the calling code:

ret = sony_call_snc_handle(0, 0, &result);

it returns 0.

sony_find_snc_handle should return -1 when called with handle == -1, right?
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux