Il 04/06/2011 09:58, Mattia Dongili wrote:
-static void sony_nc_kbd_backlight_resume(void);
-
-enum sony_nc_rfkill {
- SONY_WIFI,
- SONY_BLUETOOTH,
- SONY_WWAN,
- SONY_WIMAX,
- N_SONY_RFKILL,
-};
removing this enum seems superfluous (it's re-added some patches later)
and breaks compilation at this point.
Sorry, I made a mistake, I'm going to fix and resend patches #10 and #11.
static struct kbd_backlight *kbdbl_handle;
+static int sony_kbd_handle = -1;
there seems to be no real point initializing this to -1.
Just for safety, since handle 0x0000 is a valid handle [1] it would be
better to initialize it to an invalid value.
Also, can it be
made part of the struct above?
Sure
[1]
sony_laptop: found handle 0x0000 (offset: 0x0d)
sony_laptop: called SN07 with 0x000d (result: 0x0000)
--
To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
