On Sat, Jun 04, 2011 at 12:30:44PM +0200, Marco Chiappero wrote: > Il 04/06/2011 09:58, Mattia Dongili wrote: ... > >> static struct kbd_backlight *kbdbl_handle; > >>+static int sony_kbd_handle = -1; > > > >there seems to be no real point initializing this to -1. > > Just for safety, since handle 0x0000 is a valid handle [1] it would > be better to initialize it to an invalid value. 0x0 is not valid, it's just the lack of a value. For sure it's not a valid value for the keyboard backlight handle. ... > [1] > sony_laptop: found handle 0x0000 (offset: 0x0d) > sony_laptop: called SN07 with 0x000d (result: 0x0000) this is only going through the handles buffer and telling you that at 0x0d there is nothing. -- mattia :wq! -- To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
