Re: [PATCH] Complete PLI handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On 14/02/2020 15:46, Saúl Ibarra Corretgé wrote:
> On 06/12/2019 10:49, Nanang Izzuddin wrote:
>> Hi Saúl,
>> Actually we've also just implemented it, please check
>> I've checked your patch and I
>> think all the features have also covered by the ticket (please let us
>> know if something is missing), perhaps the difference is just who do the
>> RTCP sending, instead of PJSUA-LIB (side by side with the SIP INFO
>> method), the ticket does it in video stream. Also the ticket includes
>> SDP attribute generation to signal RTCP-FB PLI capability.
> Hi again Nanag!
> I just spent some time rebasing my changes on top of latest master
> (thanks for syncing up GitHub, it make my life heaps easier!). Great
> work folks, most of my patches are no longer necessary!
> There is, however, one thing whicch AFAICT is not currently implemented
> by PJSUA: sending a PLI when PJMEDIA_EVENT_KEYFRAME_MISSING is received
> The attached patches add this functionality. The first one exposes a
> pjmedia_vid_stream_send_rtcp_pli function which the second patch uses.
> Please let me know what you think and if you need me to make any
> changes. Keeping our patches at the minimum is my goal :-)
> Cheers,

Now you folks have moved fully to GH (awesome!) I send thesse as a PR:


Visit our blog:

pjsip mailing list

[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux