Hi Saúl,
Actually we've also just implemented it, please check https://trac.pjsip.org/repos/ticket/1437. I've checked your patch and I think all the features have also covered by the ticket (please let us know if something is missing), perhaps the difference is just who do the RTCP sending, instead of PJSUA-LIB (side by side with the SIP INFO method), the ticket does it in video stream. Also the ticket includes SDP attribute generation to signal RTCP-FB PLI capability.
Anyway, thank you so much for sharing patches, please keep sharing :)
BR,
nanang
On Wed, Dec 4, 2019 at 5:27 PM Saúl Ibarra Corretgé <saghul@xxxxxxxxx> wrote:
Hey there,
Good to be back hacking on PJSIP :-)
I noticed some nice improvements in parsing RTCP feedback packets, nice!
Full PLI support looked to be in the TODO list, and since we (Jitsi)
need it for a project, here are some patches which complete PLI support
by building on top of the existing APIs and adding where needed.
Patch 001: makes vid_stream automagically send a keyframe when a PLI is
received.
Patch 002: adds an API to vid_stream in order to send a PLI packet.
Patch 003: make pjsua (also) send PLI packets when a keyframe is missing.
Cheers,
--
Saúl
_______________________________________________
Visit our blog: http://blog.pjsip.org
pjsip mailing list
pjsip@xxxxxxxxxxxxxxx
http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
_______________________________________________ Visit our blog: http://blog.pjsip.org pjsip mailing list pjsip@xxxxxxxxxxxxxxx http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
