Possible bug (Buffer overflow) - PJSUA unable to handle SIP message sent via Cisco 8510 MCU when registered to a Cisco VCS via TCP/TLS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

I'm glad its working. I'd assume increasing the max packet length is 
harmless except for increased memory usage. I would have expected the 
UDP transport to trigger some kind of error if the SDP was cropped, the 
code can check the number of bytes read and compare against the 
content-length header to detect this.

Bill

On 6/27/2014 12:23 PM, Swinney C. wrote:
>> -----Original Message-----
>> From: Bill Gardner
>> Subject: Re: Possible bug (Buffer overflow) - PJSUA unable to handle
>> SIP message sent via Cisco 8510 MCU when registered to a Cisco VCS via
>> TCP/TLS
>>
>> Hi,
>>
>> Try increasing PJSIP_MAX_PKT_LEN (default 4000). I think you may be
>> going over that, the SDP is 2660 bytes and the header has a lot of
>> Record-Route lines. I find it surprising that it works correctly using UDP.
>>
>> Bill
>>
> Thanks Bill. I added the line:
>
> 	# define PJSIP_MAX_PKT_LEN 6000
>
> To the config_site.h file and re-compiled, then re-tested. This time all SIP calls from various types of MCU through the VCSs worked as expected. Many thanks for this.
>
> Can I take it that we may well have been on the cusp of a buffer limit with the default setting, hence the reason why it worked with UDP but not TCP? With some MCUs (an SD Cisco 8420) we also previously also received a "Bad SDP" error, but this too has disappeared. What are the downsides of increasing the buffer size? I have chosen 6000 as an arbitrary figure, but is this too much?
>
> Many thanks
>
> Chris
>




[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux