Potential bug in on_rx_rtp(transport_udp.c)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Yeah, when you call pjmedia_transport_attach, rtp_src_addr will be reset to
zero.

But.  In most cases, this won't be a problem.  I think that in certain step
of a call, rtp_src_addr will be set to correct value after attach media.
Just don't know where.

On Mon, May 11, 2009 at 9:42 PM, Michael Broughton <
Michael_Broughton at advanis.ca> wrote:

> Peter Cai wrote:
>
>> Recently I found a potential bug in PJSIP.
>>
>> In the branch I marked "BUG",  the code access the "udp->rtp_src_addr",
>> and this runs in the thread created by "pjmedia_endpt_create".
>> But the rtcp_src_addr might be reset to all "0" in main event process
>> thread.  Which would then cause an assert fail.
>> (I can find the excat place where rtp_src_addr of a transport is
>> modified.)
>>
>> A trivial walk aroud is use PJMEDIA_UDP_NO_SRC_ADDR_CHECKING when create
>> this transport,  which would skip the whole branch.
>>
> I am experiencing this issue as well. It seems to happen in a couple
> different places (on_rx_rtp, on_rx_rtcp).
>
> I guessed that the address fields are being zeroed out in another thread
> that calls transport_attach. However, I have not been able to confirm this.
>
>
> --
> Michael Broughton, Advanis
>
> Unintended Recipient & Unauthorized Use of E-Mail:
> This message and attachments may contain confidential or privileged
> information that is intended only for the named recipient of this
> e-mail. Any unauthorized use or distribution is not permitted. If you
> have received this e-mail in error, deleting the e-mail and notifying
> the sender would be appreciated. Thank you.
>
>
> _______________________________________________
> Visit our blog: http://blog.pjsip.org
>
> pjsip mailing list
> pjsip at lists.pjsip.org
> http://lists.pjsip.org/mailman/listinfo/pjsip_lists.pjsip.org
>



-- 
look to the things around you,the immediate world around you, if you are
alive,it will mean something to you ??Paul Strand
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/attachments/20090511/c5d1244c/attachment.html>


[Index of Archives]     [Asterisk Users]     [Asterisk App Development]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [Linux API]
  Powered by Linux