On Mon, Jul 24, 2017 at 9:08 PM, Jeff Janes <jeff.janes@xxxxxxxxx> wrote: > On Sun, Jul 16, 2017 at 8:47 AM, Michael Paquier <michael.paquier@xxxxxxxxx> > wrote: >> What do you think about the patch attached? > > Looks OK. Should it mention specifically "On a hot standby" rather than "On > a standby"? Otherwise people might be left confused on how they are > supposed to do this on a generic standby. It is the kind of thing which is > obvious once you know it, but confusing the first time you encounter it. Yes, right. Let's update as you suggest. >> <para> >> You can retrieve a list of WAL sender processes via the >> - <link linkend="monitoring-stats-views-table"> >> + <link linkend="monitoring-stats-dynamic-views-table"> >> <literal>pg_stat_replication</></link> view. Large differences >> between >> In the previous paragraph I have noticed that the link reference is >> incorrect. pg_stat_replication is listed under >> monitoring-stats-dynamic-views-table. > > Yes, that is clearly wrong. But why not link directly to the description of > the view itself, pg-stat-replication-view, rather than the correct table > which mentions the view? Is that the accepted docs style to link to the > more generic place? (Same thing applies to your patch, it could link > directly to pg-stat-wal-receiver-view. Yes, that's even better. > Sorry for the delay, it took me awhile to get the new doc build system to > work (solution seems to be, "Don't use CentOS6 anymore") :) Thanks for the review. -- Michael
Attachment:
walreceiver-doc-v2.patch
Description: Binary data
-- Sent via pgsql-general mailing list (pgsql-general@xxxxxxxxxxxxxx) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-general
