Checking of NULL with __GFP_NOFAIL in kzalloc()

[Manish Katiyar <mkatiyar@xxxxxxxxx>]

Hi,

While going through jbd code, I was wondering why do we need to check
new_transaction for NULL, if we are passing __GFP_NOFAIL ?
Last code change around this code was when Ted converted kmalloc to
kzalloc, but since he also didn't remove it I am guessing there would
be some good reason for it. Can someone enlighten me ?

start_this_handle() {
..........
       ..........
       new_transaction = kzalloc(sizeof(*new_transaction),
                       GFP_NOFS|__GFP_NOFAIL);
       if (!new_transaction) {
               ret = -ENOMEM;
               goto out;
       }
       ..........
}


Thanks -
Manish

--
To unsubscribe from this list: send an email with
"unsubscribe kernelnewbies" to ecartis@xxxxxxxxxxxx
Please read the FAQ at http://kernelnewbies.org/FAQ